Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move podio_PYTHON_DIR to the top level CMakeLists #497

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Move podio_PYTHON_DIR to the top level CMakeLists #497

merged 1 commit into from
Oct 4, 2023

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Move podio_PYTHON_DIR to the top level CMakeLists so that it is set even when BUILD_TESTING is off

ENDRELEASENOTES

This is useful when building other packages at the same time and having BUILD_TESTING=OFF. Alternatively, to reduce the number of lines in the top level CMakeLists the if(BUILD_TESTING) could be moved inside the tests/CMakeLists.txt and this variable could be always be set there

@tmadlener
Copy link
Collaborator

Shouldn't dependent packages get this via the find_package, where it is set? This is mainly a curiosity, I don't see any reason to not merge this.

@jmcarcell
Copy link
Member Author

Yes if you build podio, install it and then build something else. No if you use add_directory or FetchContent to build podio together with some other packages. In general everything that is not being hardcoded like this path works fine with this approach

@tmadlener
Copy link
Collaborator

Thanks for the clarification.

@tmadlener tmadlener merged commit 4d6c0b7 into AIDASoft:master Oct 4, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener